18513 Changed transition from "expand" to "slide-y" #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severinbeauvais
requested review from
ketaki-deodhar,
JazzarKarim and
leodube-aot
severinbeauvais
commented
Nov 9, 2023
| @@ -11,7 +11,7 @@ | |||
| <span class="pl-2 help-label">{{ !helpToggle ? helpLabel : 'Hide Help' }}</span> | |||
| </div> | |||
|
|
|||
| <v-expand-transition> | |||
| <v-slide-y-transition hide-on-leave> | |||
There was a problem hiding this comment.
I also tried "expand" with hide-on-leave (which has no effect), and "scale" (which explodes on the screen kinda weird), and "scroll-y" (which looks almost the same as slide-y). Ultimately, "slide-y" with the option looks best to me.
JazzarKarim
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#18513
Description of changes:
Since the expand transition was jerky, I changed it to "slide-y" along with the
hide-on-leaveoptions.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).